New Module: ShowQueueComment

English! place to talk about development, programming and coding
Post Reply
reneeb
Znuny guru
Posts: 5018
Joined: 13 Mar 2011, 09:54
Znuny Version: 6.0.x
Real Name: Renée Bäcker
Company: Perl-Services.de
Contact:

New Module: ShowQueueComment

Post by reneeb »

Perl / Znuny development: http://perl-services.de
Free Znuny add ons from the community: http://opar.perl-services.de
Commercial add ons: http://feature-addons.de
eandrex
Znuny expert
Posts: 213
Joined: 04 Nov 2012, 23:58
Znuny Version: OTRS 4.x
Real Name: Esteban
Company: NORTON DE COLOMBIA

Re: New Module: ShowQueueComment

Post by eandrex »

Wow, i didnt know i could manipulate the HTML output that way :shock: :shock:

if i had to do this ext, i would go by creating a normal frontend module, then add a javascript file to the loader of the module i need to manipulate (CustomerTicketMessage, etc) and then in that javascript, do ajax requests to the frontend module i created.

I guess everyday you learn something :lol:
Giulio Soleni
Znuny wizard
Posts: 392
Joined: 30 Dec 2010, 14:35
Znuny Version: 6.0.x and 5.0.x
Real Name: Giulio Soleni
Company: IKS srl

Re: New Module: ShowQueueComment

Post by Giulio Soleni »

Hallo Renéè,
I think that your ShowQueueComment addon could be very helpful to me, however I tested it on the last available 4.0.x framework (today 4.0.14) and it didn't work as expected.
Could it be due to the fact it's based upon the FilterElementPre Output Filter mechanism that has been deprecated and then dismissed on 5.0.x framework?

I see on the other hand that you did not release any update of the module for 5.0.x framework.
May I kindly ask if you plan to maintain it anymore?

Thank you very much in advance!
Giulio
OTRS 6.0.x on CentOS 7.x with MariaDB 10.2.x database connected to an Active Directory for Agents and Customers.
ITSM and FAQ modules installed.
reneeb
Znuny guru
Posts: 5018
Joined: 13 Mar 2011, 09:54
Znuny Version: 6.0.x
Real Name: Renée Bäcker
Company: Perl-Services.de
Contact:

Re: New Module: ShowQueueComment

Post by reneeb »

I just uploaded a new version: http://opar.perl-services.de/dist/ShowQ ... ment-5.0.1

This should work in OTRS5 and OTRS4... If you experience any issues, please let me know and please give more details, e.g. which dialogs you tested.
Perl / Znuny development: http://perl-services.de
Free Znuny add ons from the community: http://opar.perl-services.de
Commercial add ons: http://feature-addons.de
Giulio Soleni
Znuny wizard
Posts: 392
Joined: 30 Dec 2010, 14:35
Znuny Version: 6.0.x and 5.0.x
Real Name: Giulio Soleni
Company: IKS srl

Re: New Module: ShowQueueComment

Post by Giulio Soleni »

Thank you very much Renée! far better than many other business technical support!! :D

I tested your last version of ShowQueueComments on a OTRS 5.0.5 on CentOS 7 and I have to report a small bug.
Excellent as for AgentTicketPhone and AgentTicketEmail frontends, however as I added CustomerTicketMessage on the Templates list of
Frontend::Output::FilterElementPost###OutputFilterShowQueueComment in SysConfig I got a HTTP 500 Internal Server Error as soon as I try to create a ticket from the customer console.

On the logs I could see some errors like the following:
Module Kernel/Output/HTML/FilterElementPost/ShowQueueComment.pm not in @INC (/opt/otrs/Custom /opt/otrs/Kernel/cpan-lib /opt/otrs/ /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 . /etc/httpd)

And indeed the ShowQueueComment.pm perl module has been deployed under /Custom/Kernel/Output/HTML/FilterElementPost/ while there is no folder named just Kernel/Output/HTML/FilterElementPost/

I think that it's just a matter of displacing the module under the correct path.

Thank you very much again for your excellent work and support!

Giulio
OTRS 6.0.x on CentOS 7.x with MariaDB 10.2.x database connected to an Active Directory for Agents and Customers.
ITSM and FAQ modules installed.
reneeb
Znuny guru
Posts: 5018
Joined: 13 Mar 2011, 09:54
Znuny Version: 6.0.x
Real Name: Renée Bäcker
Company: Perl-Services.de
Contact:

Re: New Module: ShowQueueComment

Post by reneeb »

No, the Custom folder is in @INC. You should check if you still get the error message...

You issue with the custom portal is fixed as of version 5.0.2: http://opar.perl-services.de/dist/ShowQ ... ment-5.0.2
Perl / Znuny development: http://perl-services.de
Free Znuny add ons from the community: http://opar.perl-services.de
Commercial add ons: http://feature-addons.de
Giulio Soleni
Znuny wizard
Posts: 392
Joined: 30 Dec 2010, 14:35
Znuny Version: 6.0.x and 5.0.x
Real Name: Giulio Soleni
Company: IKS srl

Re: New Module: ShowQueueComment

Post by Giulio Soleni »

That's perfect Renée! All works as expected, thank you very much.

Since I would like to have a translation result of the queue comments, I have taken the liberty of modifying a line in your code in ShowQueueComment.pm thus:

Code: Select all

my $Key = sprintf "%s||%s", $QueueID, $QueueInfo{Name};
$Mapping->{$Key} = $QueueInfo{Comment};
for me has been changed into

Code: Select all

my $Key = sprintf "%s||%s", $QueueID, $QueueInfo{Name};
$Mapping->{$Key} = $LayoutObject->{LanguageObject}->Translate($QueueInfo{Comment});
I would like to learn more about Output Filters in general but the official developer manual provides only few information on this topic...
Do you know where I could retrieve a tutorial or some further examples?

Thank you again!
Giulio
OTRS 6.0.x on CentOS 7.x with MariaDB 10.2.x database connected to an Active Directory for Agents and Customers.
ITSM and FAQ modules installed.
Post Reply